Skip to content
Snippets Groups Projects
  1. Oct 21, 2013
    • Nick Kralevich's avatar
      Move unconfined domains out of permissive mode. · 353c72e3
      Nick Kralevich authored
      This change removes the permissive line from unconfined
      domains. Unconfined domains can do (mostly) anything, so moving
      these domains into enforcing should be a no-op.
      
      The following domains were deliberately NOT changed:
      1) kernel
      2) init
      
      In the future, this gives us the ability to tighten up the
      rules in unconfined, and have those tightened rules actually
      work.
      
      When we're ready to tighten up the rules for these domains,
      we can:
      
      1) Remove unconfined_domain and re-add the permissive line.
      2) Submit the domain in permissive but NOT unconfined.
      3) Remove the permissive line
      4) Wait a few days and submit the no-permissive change.
      
      For instance, if we were ready to do this for adb, we'd identify
      a list of possible rules which allow adbd to work, re-add
      the permissive line, and then upload those changes to AOSP.
      After sufficient testing, we'd then move adb to enforcing.
      We'd repeat this for each domain until everything is enforcing
      and out of unconfined.
      
      Change-Id: If674190de3262969322fb2e93d9a0e734f8b9245
      353c72e3
  2. Oct 16, 2013
  3. Oct 15, 2013
    • William Roberts's avatar
      tools: drop unused field in struct · d1f1070a
      William Roberts authored
      check_seapp at one point in time switch from a home implementation
      of a hash table to using GLIBC search.h routines. A struct in one
      of the fields was never removed during this transition.
      
      Change-Id: I65c028103ffe90fa52e0b3c9fce28124ed9c7ff9
      d1f1070a
  4. Oct 14, 2013
    • William Roberts's avatar
      tools: Strengthen BEGIN/END CERTIFICATE checks · 14138335
      William Roberts authored
      insertkeys.py used beginswith() when checking that the BEGIN
      and END CERTIFICATE clauses in PEM files were correct. It should
      have done an explicit check on equality.
      
      Change-Id: I5efb48d180bc674e6281a26a955acd248588b8bd
      14138335
  5. Oct 10, 2013
    • Mike Palmiotto's avatar
      tools: Don't error out of insertkeys script on whitespace · 070c01f8
      Mike Palmiotto authored
      Many keys end with whitespace or otherwise have whitespace separating the
      certificates.  If insertkeys is intended to support multiple certificates, we
      should also support blank line separators.
      
      Change-Id: I5fd17be5785ad1b89a6191e9ba33bbc7c5a4e8e9
      070c01f8
    • Nick Kralevich's avatar
      Allow apps to use the USB Accessory functionality · 0b8c20e7
      Nick Kralevich authored
      Apps may need to access the USB Accessory interface, which
      involves reads / writes / etc to /dev/usb_accessory
      and /dev/bus/usb/*
      
      See http://developer.android.com/guide/topics/connectivity/usb/accessory.html
      for more information.
      
      This addresses the following denials:
      
      [   80.075727] type=1400 audit(1379351306.384:9): avc:  denied  { read write } for  pid=496 comm="Binder_1" path="/dev/usb_accessory" dev=tmpfs ino=5320 scontext=u:r:untrusted_app:s0 tcontext=u:object_r:usbaccessory_device:s0 tclass=chr_file
      [   86.204387] type=1400 audit(1379304688.579:10): avc:  denied  { getattr } for  pid=1750 comm="Thread-126" path="/dev/usb_accessory" dev=tmpfs ino=5320 scontext=u:r:untrusted_app:s0 tcontext=u:object_r:usbaccessory_device:s0 tclass=chr_file
      [ 2773.581032] type=1400 audit(1379307375.959:22): avc:  denied  { read write } for  pid=761 comm="Binder_A" path="/dev/bus/usb/002/002" dev=tmpfs ino=12862 scontext=u:r:untrusted_app:s0 tcontext=u:object_r:usb_device:s0 tclass=chr_file
      [ 2773.590843] type=1400 audit(1379307375.969:23): avc:  denied  { getattr } for  pid=5481 comm="android.app" path="/dev/bus/usb/002/002" dev=tmpfs ino=12862 scontext=u:r:untrusted_app:s0 tcontext=u:object_r:usb_device:s0 tclass=chr_file
      [ 2773.591111] type=1400 audit(1379307375.969:24): avc:  denied  { ioctl } for  pid=5481 comm="android.app" path="/dev/bus/usb/002/002" dev=tmpfs ino=12862 scontext=u:r:untrusted_app:s0 tcontext=u:object_r:usb_device:s0 tclass=chr_file
      
      Bug: 10780497
      Change-Id: I9663222f7a75dcbf3c42788a5b8eac45e69e00bb
      0b8c20e7
  6. Oct 09, 2013
  7. Oct 08, 2013
    • William Roberts's avatar
      tools: Correct insert keys behavior on pem files · 1ecb4e8a
      William Roberts authored
      Insert keys would erroneously process pem files
      with openssl headers in them. Also, the tool would
      be fooled into attempting to use pem files that
      had private keys and other things in the format.
      This patch strengthens the formatting requirements
      and increases the verboseness of error messages
      when processing pem files.
      
      Change-Id: I03353faaa641233a000d1a18943024ae47c63e0f
      1ecb4e8a
    • William Roberts's avatar
      Start confining ueventd · 85c5fc21
      William Roberts authored
      * Keep ueventd in permissive
      * Drop unconfined macro to collect logs
      * Restore allow rules to current NSA maintained policy
      
      Change-Id: Ic4ee8e24ccd8887fed151ae1e4f197512849f57b
      85c5fc21
  8. Oct 03, 2013
  9. Oct 01, 2013
    • Stephen Smalley's avatar
      Label adb keys file and allow access to it. · 55540755
      Stephen Smalley authored
      
      The /adb_keys entry will only take effect if a restorecon is
      applied by init.rc on a kernel that includes the rootfs labeling
      support, but does no harm otherwise.
      
      The /data/misc/adb labeling ensures correct labeling of the adb_keys
      file created if the device has ro.adb.secure=1 set.
      
      Allow adbd to read the file.
      
      Change-Id: I97b3d86a69681330bba549491a2fb39df6cf20ef
      Signed-off-by: default avatarStephen Smalley <sds@tycho.nsa.gov>
      55540755
  10. Sep 30, 2013
    • Stephen Smalley's avatar
      Restore netdomain allow rules. · ca0759b1
      Stephen Smalley authored
      
      Change I4be1c987a5d69ac784a56d42fc2c9063c402de11 removed all
      netdomain allow rules at the same time domains were made unconfined.
      Prior to that change, any domain that used the net_domain() macro
      would be granted permissions required to use the network via these rules.
      The change made the netdomain attribute unused in any rules, thereby
      rendering the net_domain() calls pointless and requiring the allow
      rules to be duplicated for any domain requiring network access. There
      are two ways to resolve this inconsistency:
      1.  Restore the netdomain rules as in this change.  In that case,
      some rules in app.te can be removed as they are redundant with these rules.
      -or-
      2.  Completely remove the netdomain attribute, the net_domain() macro,
      and all calls to it.  In that case, each domain that requires network
      access will need to duplicate these rules or the necessary subset in order
      to function.
      
      Signed-off-by: default avatarStephen Smalley <sds@tycho.nsa.gov>
      
      Change-Id: Ia54f0cd0bbda5c510423b1046626bd50f79ed7b6
      ca0759b1
    • Stephen Smalley's avatar
      Except the shell domain from the transition neverallow rule. · 57085446
      Stephen Smalley authored
      
      Shell domain can transition to other domains for runas, ping, etc.
      
      Change-Id: If9aabb4f51346dc00a89d03efea25499505f278d
      Signed-off-by: default avatarStephen Smalley <sds@tycho.nsa.gov>
      57085446
  11. Sep 28, 2013
  12. Sep 27, 2013
  13. Sep 26, 2013
  14. Sep 23, 2013
  15. Sep 20, 2013
  16. Sep 19, 2013
    • Stephen Smalley's avatar
      Label /dev/socket/mdns with its own type. · 4caf8c99
      Stephen Smalley authored
      
      Otherwise it gets left in the general device type, and we get denials such
      as:
      type=1400 msg=audit(1379617262.940:102): avc:  denied  { write } for  pid=579 comm="mDnsConnector" name="mdns" dev="tmpfs" ino=3213 scontext=u:r:system_server:s0 tcontext=u:object_r:device:s0 tclass=sock_file
      
      This of course only shows up if using a confined system_server.
      
      Change-Id: I2456dd7aa4d72e6fd15b55c251245186eb54a80a
      Signed-off-by: default avatarStephen Smalley <sds@tycho.nsa.gov>
      4caf8c99
  17. Sep 18, 2013
  18. Sep 17, 2013
    • Alex Klyubin's avatar
      2/2: Rename domain "system" to "system_server". · 4103b3f2
      Alex Klyubin authored
      This CL completes the renaming of domain system to system_server by
      removing the "system" typealias that was temporarily added to avoid
      breaking the build while the rename CLs are landing.
      
      Change-Id: I05d11571f0e3d639026fcb9341c3476d44c54fca
      4103b3f2
    • Alex Klyubin's avatar
      1/2: Rename domain "system" to "system_server". · 1fdee11d
      Alex Klyubin authored
      This is a follow-up CL to the extraction of "system_app" domain
      from the "system" domain which left the "system" domain encompassing
      just the system_server.
      
      Since this change cannot be made atomically across different
      repositories, it temporarily adds a typealias "server" pointing to
      "system_server". Once all other repositories have been switched to
      "system_server", this alias will be removed.
      
      Change-Id: I90a6850603dcf60049963462c5572d36de62bc00
      1fdee11d
  19. Sep 13, 2013
Loading